Skip to content

ironside: se: Add support for calling the cpuconf service #22034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ironside: se: Add support for calling the cpuconf service #22034

wants to merge 1 commit into from
+119 −1

Conversation

@SebastianBoe
Copy link
Contributor

@SebastianBoe SebastianBoe commented Apr 24, 2025

Add support for calling the cpuconf service.

Ref: NCSDK-32925

@SebastianBoe SebastianBoe requested review from a team as code owners April 24, 2025 08:19
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 24, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 24, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 9

Inputs:

Sources:

sdk-nrf: PR head: 960f5b45ae1da49d57c972fa3d68447059ffade2
zephyr: PR head: 30837c754c482bfee0c07403e8bd29dae580d35b

more details

sdk-nrf:

PR head: 960f5b45ae1da49d57c972fa3d68447059ffade2
merge base: c90f6c4d90d9337b97abd474f6a848969ca31096
target head (main): c90f6c4d90d9337b97abd474f6a848969ca31096
Diff

zephyr:

PR head: 30837c754c482bfee0c07403e8bd29dae580d35b
merge base: 25cb489d37e37688cc1a9ae08b5c3658e48407fc
target head (main): ca2af2f1469802d7e48b18a6e8bce6436d57223c
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (20) 
CODEOWNERS
include
│  ├── ironside
│  │  ├── se
│  │  │  │ cpuconf.h
lib
│  ├── CMakeLists.txt
│  ├── Kconfig
│  ├── cpuconf
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  │ cpuconf.c
west.yml
zephyr
│  ├── boards
│  │  ├── nordic
│  │  │  ├── nrf54h20dk
│  │  │  │  ├── Kconfig.nrf54h20dk
│  │  │  │  ├── board.cmake
│  │  │  │  ├── board.yml
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp_iron.dts
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpurad_iron.dts
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpurad_iron_0_9_0.yaml
│  │  │  │  │ nrf54h20dk_nrf54h20_cpurad_iron_defconfig
│  ├── samples
│  │  ├── sysbuild
│  │  │  ├── hello_world
│  │  │  │  ├── boards
│  │  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp_iron.conf
│  │  │  │  ├── sample.yaml
│  │  │  │  ├── sysbuild
│  │  │  │  │  │ nrf54h20dk_nrf54h20_cpurad_iron.conf
│  ├── soc
│  │  ├── nordic
│  │  │  ├── nrf54h
│  │  │  │  ├── Kconfig
│  │  │  │  │ soc.c

Outputs:

Toolchain

Version: 1d2c5d0ab5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:1d2c5d0ab5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 1386
    • sdk-zephyr test count: 477
  • ❌ Integration tests
    • ❌ test-sdk-audio
    • ❌ test-fw-nrfconnect-chip
    • ❌ test-fw-nrfconnect-nfc
    • ❌ test-fw-nrfconnect-nrf-iot_cloud
    • ❌ test-fw-nrfconnect-rs
    • ❌ test-fw-nrfconnect-fem
    • ❌ test-fw-nrfconnect-thread
    • ❌ test-sdk-find-my
    • ❌ test-low-level
    • ❌ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Apr 24, 2025 •
edited
Loading

You can find the documentation preview for this PR here.

@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 28, 2025
frkv
frkv approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@frkv frkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (some minor compliance on spacing)

degjorva
degjorva approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@degjorva degjorva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, looks good

lib/cpuconf/cpuconf.c Outdated
Copy link
Contributor

@degjorva degjorva Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int ironside_se_cpuconf_boot_radiocore(uint8_t *msg, size_t msg_size)
psa_status_t ironside_se_cpuconf_boot_radiocore(uint8_t *msg, size_t msg_size)

degjorva
degjorva reviewed Apr 28, 2025
View reviewed changes
include/ironside/se/cpuconf.h Outdated
Copy link
Contributor

@degjorva degjorva Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int ironside_se_cpuconf_boot_radiocore(uint8_t *msg, size_t msg_size);
psa_status_t ironside_se_cpuconf_boot_radiocore(uint8_t *msg, size_t msg_size);

@SebastianBoe SebastianBoe force-pushed the cpuconf branch 4 times, most recently from 90be5e0 to faa9528 Compare April 28, 2025 14:03
@SebastianBoe SebastianBoe requested a review from a team as a code owner April 28, 2025 14:03
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 28, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@ca2af2f (main) nrfconnect/sdk-zephyr#2815 nrfconnect/sdk-zephyr#2815/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@SebastianBoe
ironside: se: Add support for calling the cpuconf service
960f5b4 
Add support for calling the cpuconf service.

Ref: NCSDK-32925

Signed-off-by: Sebastian Bøe <[email protected]>
@SebastianBoe
Copy link
Contributor Author

SebastianBoe commented May 1, 2025

Moving this code to Zephyr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@degjorva degjorva degjorva approved these changes

@frkv frkv frkv approved these changes

@nordicjm nordicjm nordicjm approved these changes

Assignees

No one assigned

Labels

DNM manifest manifest-zephyr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SebastianBoe @NordicBuilder @degjorva @frkv @nordicjm